Add configurable support for non-ASCII languages in Slugify #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a `SupportNonAsciiLanguages` option in `SlugHelperConfiguration` to enable handling of non-ASCII characters. Updated `SlugHelper` to use this option, replacing the now-obsolete `SlugHelperForNonAsciiLanguages` class. Refactored tests and benchmarks to use the new configuration, adding comprehensive test cases for various languages and edge cases. Removed redundant methods and tests tied to the old approach. Updated project files to reflect version changes, signaling the introduction of this streamlined and unified feature. Related Work Items: ctolkien#155
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a
SupportNonAsciiLanguagesoption inSlugHelperConfigurationto enable handling of non-ASCII characters. UpdatedSlugHelperto use this option, replacing the now-obsoleteSlugHelperForNonAsciiLanguagesclass.Refactored tests and benchmarks to use the new configuration, adding comprehensive test cases for various languages and edge cases. Removed redundant methods and tests tied to the old approach.
Updated project files to reflect version changes, signaling the introduction of this streamlined and unified feature.
Related Work Items: #157