8000 changed hasHole so that it allows for certain non-manifold geometries… by justinlaughlin · Pull Request #53 · ctlee/gamer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

changed hasHole so that it allows for certain non-manifold geometries… #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

changed hasHole so that it allows for certain non-manifold geometries… #53

wants to merge 1 commit into from

Conversation

justinlaughlin
Copy link
Collaborator

… (e.g. edge connected to three faces)

Description

I want to generate a binary. Also I think this change is generally good because hasHole should only check for a 806A hole, not general non-manifoldness.

Todos

  • Allows for some non-manifold geometries to be tetrahedralized (this is allowed on TetGen's side).

Questions

  • Does this break anything else? I don't think so. Couldn't find any other usages of hasHole().

Status

  • Ready to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@justinlaughlin
0