8000 gherkin-python: Sync the release process with tag-expressions-python by brasmusson · Pull Request #1458 · cucumber/common · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

gherkin-python: Sync the release process with tag-expressions-python #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

brasmusson
Copy link
Contributor

Summary

Sync the release process with tag-expressions-python

Details

  • rsync the default.mk from .templates
  • Include default.mk in the Makefile
  • Update setup.py
    • Change to use double quotes (") instead of single quotes (') to
      enable the use of the update-version make rule
    • Change the download_url the publish make rule uploads the release
      archive to pypi (which was not done earlier for the gherkin-python
      releases).
    • Add (a short) long_description and platforms so that the PKG-INFO
      in the created distribution does not have any entries with the value
      UNKNOWN
  • Commit the MANIFEST (which was updated when testing to create the
    source distribution locally).

Motivation and Context

How Has This Been Tested?

Locally tested update-version and python2 setup.py sdist (the latter is the first have of the publish make rule).

Types of changes

  • Bug fix in the release process for gherkin-python (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • The change has been ported to Java.
  • The change has been ported to Ruby.
  • The change has been ported to JavaScript.
  • The change has been ported to Go.
  • The change has been ported to .NET.
  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG accordingly.

* rsync the default.mk from .templates
* Include default.mk in the Makefile
* Update setup.py
  * Change to use double quotes (") instead of single quotes (') to
    enable the use of the update-version make rule
  * Change the download_url the publish make rule uploads the release
    archive to pypi (which was not done earlier for the gherkin-python
    releases).
  * Add (a short) long_description and platforms so that the PKG-INFO
    in the created distribution does not have any entries with the value
    UNKNOWN
* Commit the MANIFEST (which was updated when testing to create the
  source distribution locally).
@brasmusson
Copy link
Contributor Author

@aslakhellesoy I recon that cukebot needs to be added as a maintainer of https://pypi.org/project/gherkin-official/ (as it is for https://pypi.org/project/cucumber-tag-expressions/)

@aslakhellesoy aslakhellesoy merged commit 5906a23 into master Apr 6, 2021
@aslakhellesoy aslakhellesoy deleted the gherkin-python-releaseable branch April 6, 2021 20:04
@aslakhellesoy
Copy link
Contributor

Thanks @brasmusson !

@aslakhellesoy
Copy link
Contributor

I've made cukebot an owner of gherkin-official.

@aslakhellesoy
Copy link
Contributor

Version 18.1.0 is out! https://pypi.org/project/gherkin-official/#history

@jenisys in case you want to update behave to use this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0