8000 Styling tweaks for external usage by davidjgoss · Pull Request #372 · cucumber/react-components · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Styling tweaks for external usage #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 26, 2025
Merged

Styling tweaks for external usage #372

merged 6 commits into from
Mar 26, 2025

Conversation

davidjgoss
Copy link
Contributor
@davidjgoss davidjgoss commented Mar 26, 2025

🤔 What's changed?

Some small styling tweaks to better support usage in external React apps, especially those using a CSS reset like Cucumber Reports. Specifically:

  • Headings rendered with the <Title> element now have a font size specified, rather than relying on the browser defaults
  • SVG elements in the <ExecutionSummary> component are specified as inline-block to ensure they are centered
  • Custom properties --cucumber-sans-font-family and --cucumber-mono-font-family can now be used to override the fonts

⚡️ What's your motivation?

Better styling integration in Cucumber Reports.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)
  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Copy link
netlify bot commented Mar 26, 2025

Deploy Preview for cucumber-react-preview ready!

Name Link
🔨 Latest commit a502cca
🔍 Latest deploy log https://app.netlify.com/sites/cucumber-react-preview/deploys/67e3cd0a6a1bfa000881d034
😎 Deploy Preview https://deploy-preview-372--cucumber-react-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@davidjgoss davidjgoss marked this pull request as ready for review March 26, 2025 09:48
@davidjgoss davidjgoss merged commit 309a512 into main Mar 26, 2025
6 checks passed
@davidjgoss davidjgoss deleted the reports-fixes branch March 26, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0