Fix glue for csharp steps #144
Conversation
There was a problem hiding this comment.
Thanks for spotting and raising a fix on this @margori. Requesting if you could provide some references for the pattern being introduced? Thanks to your pull request, I notice the same issue with the respective SpecFlow pattern for feature files ("*specs*/**/.feature"), if you would be able to correct that to "*specs*/**/*.feature" also; and perhaps rename the pull request to mention your PR fixes glob paths for c-sharp steps and feature files?
There was a problem hiding this comment.
@margori, thank you for your fix, have aligned and reinstated with a previous fix to the same paths from: (#93); and additionally fixed the glob for feature files in csharp projects.
As it was never updated in the Language Server previously, when the list of glob patterns was extended for new languages within this repository, they were also applied back into the VSCode repo (following documented procedure) and included the previous patterns for C# - inadvertently reverting the fix. This is now resolved and the changes are also in the Language Server (cucumber/language-server#89).
If you can locate evidence of the additional proposed path ("*step*/**/*.cs",) being a convention and that it should be a smart default, please raise a PR within the Language Server repository and link back to this PR.
|
Hi @margori, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
🤔 What's changed?
Fix the glue for CSharp step definitions
⚡️ What's your motivation?
The filter for CSharp step definitions did not have a '*'
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
None
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.