DACCESS-548 Finding aid links direct to Aspace PUI #2272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- hide the Aeon request buttons for catalog items containing the Aspace resource id in the marc 035 field
- update the Finding aid link to direct the patron to the Aspace PUI
…g the Aspace resource id in the marc 035 field and update the Finding aid link to direct the patron to the Aspace PUI
|
@djc88 in the helper file.... the way i get the resource id value in the marc 35 field, I am not doing anything special like check its a number, hopefully that is ok? I wasn't sure what variations to expect like will they all be numeric? letter characters? space, hyphen? so the regular expression will just grab everything after the string match ('CULAspaceURI'). it passed all the example catalog item test cases they sent me, but I could be more strict here. If I remember though, this was created automatically ,so we won't have to worry about user error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.