Add sici and shichi to special for sine and cosine integrals #8620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@steppi Thank you for your pull request submission! Could you please inform us about your schedule for the release of the header library submodule? |
|
/test mini |
|
@asi1024, I've added macros for some |
|
/test mini |
|
The static-checks failure seems unrelated to this PR. |
asi1024
approved these changes
Oct 1, 2024
|
@steppi LGTM! Thanks! |
|
@asi1024, I've created an RFC here, scipy/xsf#1, about the plan to create the header library submodule for special functions, if you're interested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functions
siciandshichitocupyx.scipy.specialfor evaluating sine and cosine integrals and hyperbolic sine and cosine integrals respectively. We added CUDA support for these functions to SciPy in scipy/scipy#21210.Notice that
cupy/_core/include/cupy/specialhas been renamed tocupy/_core/include/cupy/xsf. We've made this change internally in SciPy too scipy/scipy#21297, and are preparing to split this out into a separate library which SciPy and CuPy can both include as a submodule. I've updated the headers to the latest ones that are being used in SciPy.