Allow passing Ecto query and preloads as list_... function args #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c2b50a to
555b4c5
Compare
555b4c5 to
7b00130
Compare
87c371b to
50b5a67
Compare
73ee7b7 to
e1c4730
Compare
e1c4730 to
dd56b7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44.
In CRUD function generation, it will now allow calling generated
list_...functions in the following ways:list_items()- lists all resources unfilteredlist_items(query)- lists all resources filtered by the querylist_items(query, [:category, :manufacturer])- lists all resources preloaded with the associationslist_items([:category, :manufacturer])- lists all resources preloaded with the associationsPreloads can be given as an atom (
:category) or a list of atoms ([:category, :manufacturer]) just as inRepo.preload/2.The Ecto queryable argument must be either:
fromclause that targets the schema of the resource.For example,
list_items(Item)can be called just as well aslist_items(from i in Item)- these are the most commonly occurring implementations ofEcto.Queryablethat make most sense when used with a specific schema.