8000 Fixing interpolation error by Eldies · Pull Request #9403 · cvat-ai/cvat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixing interpolation error #9403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 12, 2025
Merged

Fixing interpolation error #9403

merged 9 commits into from
May 12, 2025

Conversation

Eldies
Copy link
Contributor
@Eldies Eldies commented May 8, 2025 •
edited
Loading

Motivation and context

Since https://github.com/cvat-ai/cvat/pull/8382/files#diff-c28ba6e28c4641a01ad55189d81b02ce0a00e0e6ed689f8312028f35e2bea9cfR2140 points in shapes are tuples. But copying function does not work with tuples, so fixing it

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@Eldies Eldies requested a review from zhiltsov-max as a code owner May 8, 2025 10:06
@Eldies Eldies requested a review from nmanovic as a code owner May 8, 2025 10:26
@codecov-commenter
Copy link
codecov-commenter commented May 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.84%. Comparing base (61838ba) to head (2ae7ee0).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #9403   +/-   ##
========================================
  Coverage    73.84%   73.84%           
========================================
  Files          435      435           
  Lines        45770    45770           
  Branches      3924     3924           
========================================
  Hits         33801    33801           
  Misses       11969    11969
Components Coverage Δ
cvat-ui 77.55% <ø> (ø)
cvat-server 70.87% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Eldies Eldies force-pushed the dl/fix-tuple-copy-fail branch from 621ddf0 to ec7f0f1 Compare May 12, 2025 11:12
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zhiltsov-max zhiltsov-max merged commit 7be7ff6 into develop May 12, 2025
34 checks passed
@zhiltsov-max zhiltsov-max deleted the dl/fix-tuple-copy-fail branch May 12, 2025 13:26
@cvat-bot cvat-bot bot mentioned this pull request May 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiltsov-max zhiltsov-max zhiltsov-max approved these changes

@nmanovic nmanovic Awaiting requested review from nmanovic nmanovic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eldies @codecov-commenter @zhiltsov-max
0