Release v2.36.0 #9409
Merged
Release v2.36.0 #9409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated trackers documentation after changes in TrackerMIL implementation
Update develop after v2.35.0
…9341) Removed outdated piece of documentation about Search in UI
- Added prefetch for task visibility checks for the requesting user - Added an option to reuse input object organization in IAM context retrieval, if available. Make this working with caching for jobs and quality reports - Optimized out 1 extra db request to retrieve org owner in IAM context retrieval
The current behavior is mildly inconvenient, since if the user asks for `--help` or enters an invalid command, they are still prompted for the password, even though that password isn't used. I also added a minor usability improvement, adding the server and username into the password prompt.
By default, DRF returns a 405 status code when an unexpected API method is used for an existing URL. However, the code that handles this is not called since permissions are checked before that, and our code did not assume that unsupported actions could be used.
This PR introduces various cosmetic changes in the CVAT documentation (`Getting Started`, `Integrations`, `Paid fe 8000 atures`, `Manual` sections): - `CVAT Cloud` renamed to `CVAT Online` (for consistency with the main website) - `CVAT.ai` renamed to `CVAT` as the former is the website, and the latter is the product - Markdown lazy numbering - Oxford comma - Kebab case for file names instead of snake case - fixes for changed documentation links in the source code files - grammar fixes
- Optimized webhooks list requests. Previously, for each webhook in the list there were 2 extra duplicated DB requests to get the last delivery
This feature is fundamentally insecure. If a user makes use of this, then a MitM could trivially block the HTTPS connection attempt, causing the SDK to downgrade to HTTP. Even in the absence of an active attacker, a transient error could cause a downgrade, leading to request details and credentials being exposed in cleartext. In addition, this feature creates a usability problem, because if the autodetection fails, the user is given no information about the cause. This could be fixed, but given the main issue, I don't think it's worthwhile. I don't think we can just remove this feature immediately, given that the SDK has worked this way for a long time, and there are certainly people relying on it. Therefore, in this patch I just add a big warning, and recommend specifying the scheme explicitly. In a future release, we can drop the autodetection.
<!-- Raise an issue to propose your change (https://github.com/cvat-ai/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. Describe your changes in detail, add screenshots. --> ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - [ ] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> - [ ] I have updated the documentation accordingly - [ ] I have added tests to cover my changes - [ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern.
### Motivation and context Fixes #9357 Since matchLabels are immutable, the deployment breaks if you try to add new labels to one of the cvat or worker pods. To avoid this, use a subset of unique but unchanging labels for your matchLabels - in this case these are defined by the selectorLabels template. ### How has this been tested? Tested with our helm deployment. In order to redeploy I had to run the following commands: ``` kubectl -n cvat delete --cascade=false deployment --all kubectl -n cvat delete --cascade=false sts cvat-kvrocks ``` ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - [x] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> - [ ] I have updated the documentation accordingly - [ ] I have added tests to cover my changes - [x] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern.
The new version seems to be better at parsing Markdown and emits more useful warnings (which I fixed). The new warnings are mostly of the following categories: 1. Inconsistent table formatting. 2. Inconsistent list numbering. 3. Overlong lines. 4. Missing quote markers. WRT tables, I converted a few of them to the compact style, because I can't be bothered to align rows that are >100 characters long, and I don't think anyone else should have to.
…k` (#9396) `ilink` will prevent them from being broken in the future.
…ker (#9376) Tracking with the AI model was not starting automatically after being re-enabled
…orages (#8275) - Optimized task list requests - Optimized quality conflicts requests - Optimized calls to related manifests in cloudstorages api (however, manifests should be either moved to a separate endpoint or should be limited in maximum number per CS)
A change that our marketing team asked for. They would like our customers to reach us through the website form. It allows us understand where they come from.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9409 +/- ##
==========================================
+ Coverage 73.78% 73.88% +0.09%
==========================================
Files 436 435 -1
Lines 45646 45681 +35
Branches 3937 3924 -13
==========================================
+ Hits 33682 33753 +71
+ Misses 11964 11928 -36
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
UI button to export raw resource events on analytics page (Added placeholder for analytics, added raw events export #9293)
Input size controls for cuboids in 3D workspace (Size controls for cuboid items in the 3d workspace #9356)
Changed
Export of events using the server endpoint
GET /api/eventsignoressend:exceptionscope. (Enhanced filtration of CSV export #9383)Updated default value of
fromquery parameter in GET/api/events. Now it exports all events of the target resource iffromandtoare not specified. (Enhanced filtration of CSV export #9383)Export table as CSV feature now considers applied filtration on the table (Enhanced filtration of CSV export #9383)
[CLI] The default value for
--server-hostis nowhttp://localhost(SDK: Deprecate server URL scheme autodetection #9384)Deprecated
https://orhttp://to the host explicitly to avoid future breakage (SDK: Deprecate server URL scheme autodetection #9384)Fixed
Fixed helm-chart to use selectorLabels template for matchLabels Use selectorLabels helper for matchLabels in helm #9358 (Use selectorLabels helper for matchLabels in helm #9358)
500 status code returned when an API method is not allowed (Fix 500 status code returned when an API method is not allowed #9345)
Optimized the
api/jobs/server endpoint (Optimize permission checks in jobs list #9275)Optimized DB requests for server permission checks (Optimize permission checks in jobs list #9275)
[CLI] Commands with invalid arguments or
--helpno longer ask for the server password (CLI: don't prompt for the password until arguments are parsed #9375)Improved performance of
GET /api/tasks,GET /api/quality/conflictsandGET /api/cloudstoragesrequests (Optimize DB requests in task list, quality conflicts list and cloudstorages #8275)Improved performance of
GET /api/webhooksrequests (Optimize webhooks list request #9269)Tracking with the AI model was not starting automatically after being re-enabled (Automatically set a keyframe when enabling a previously disabled tracker #9376)