8000 yolo import - use detected sources to search for annotation files by Eldies · Pull Request #9423 · cvat-ai/cvat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

yolo import - use detected sources to search for annotation files #9423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 19, 2025

Conversation

Eldies
Copy link
Contributor
@Eldies Eldies commented May 14, 2025

Motivation and context

On Yolo import, importer searches for annotations in the folder where to the archive was uncompressed to get image_info. When the archive is misstructured, e.g. when the folder with dataset was compressed and not just it's content, it works incorrectly.
Using datumaro detection to find actual source folder and search for annotations there.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@Eldies Eldies requested a review from zhiltsov-max as a code owner May 14, 2025 16:44
Copy link
Contributor
@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test and update the changelog

@Eldies Eldies requested review from SpecLad and nmanovic as code owners May 16, 2025 10:36
@Eldies
Copy link
Contributor Author
Eldies commented May 16, 2025

Please add a test and update the changelog

done.
Also, now it depends on cvat-ai/datumaro#106

@codecov-commenter
Copy link
codecov-commenter commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.50%. Comparing base (75f4d9f) to head (aec2b51).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9423      +/-   ##
===========================================
+ Coverage    73.48%   73.50%   +0.02%     
===========================================
  Files          438      438              
  Lines        46365    46366       +1     
  Branches      3938     3938              
===========================================
+ Hits         34069    34083      +14     
+ Misses       12296    12283      -13     
Components Coverage Δ
cvat-ui 77.69% <ø> (-0.01%) ⬇️
cvat-server 70.22% <100.00%> (+0.05%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor
@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the datumaro commit

@Eldies Eldies merged commit bd2a978 into develop May 19, 2025
34 checks passed
@Eldies Eldies deleted the dl/fixing-yolo-import-misstructured-archive branch May 19, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0