-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Bump Python runtime version for Segment Anything interactor Nuclio function from 3.8 to 3.10 #9593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecLad
reviewed
Jul 3, 2025
serverless/pytorch/facebookresearch/sam/nuclio/function-gpu.yaml
Outdated
Show resolved
Hide resolved
SpecLad
reviewed
Jul 10, 2025
changelog.d/20250701_144005_PercipioCorey_bump_SAM_python_version.md
Outdated
Show resolved
Hide resolved
…ion.md Co-authored-by: Roman Donchenko <rdonchen@outlook.com>
|
SpecLad
approved these changes
Jul 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9593 +/- ##
===========================================
+ Coverage 71.76% 71.86% +0.10%
===========================================
Files 441 441
Lines 46374 46374
Branches 3960 3960
===========================================
+ Hits 33279 33328 +49
+ Misses 13095 13046 -49
🚀 New features to boost your workflow:
|
Thank you for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9592
Motivation and context
The Python runtime specified in the Segment Anything Nuclio function yaml files (here and here) is version 3.8. Support for this version was dropped by Nuclio and the Nuclio handler builder image in October 2024 (source).
This PR bumps the Python runtime version specified in the affected files from 3.8 to 3.10.
How has this been tested?
This change was tested in both CPU-only and GPU environments by running the appropriate deployment scripts
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.