add option to skip kubelet update #797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca220f0 to
3a03682
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds an option to skip the kubelet update during cluster operations.
- Introduces a new boolean option (skip_update) in the kubelet configuration.
- Updates the strategy logic to conditionally bypass kubelet updates.
- Extends tests and documentation to cover the new option.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| server/strategy_test.go | Added a test case to verify that kubelet update is skipped |
| server/strategy.go | Updated condition to check the skip_update flag |
| docs/cluster.md | Documented the new skip_update option |
| cluster.go | Extended KubeletParams with the new SkipUpdate field |
Comments suppressed due to low confidence (1)
server/strategy_test.go:1016
- [nitpick] The test case name 'RestartKubelet10' may be misleading since the test is validating the skip-update behavior. Consider renaming it to better reflect that kubelet update is being skipped (e.g., 'SkipKubeletUpdate').
Name: "RestartKubelet10",
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sobobuoy