8000 Test with Ordered option by chez-shanpu · Pull Request #326 · cybozu-go/coil · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Test with Ordered option #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025
Merged

Test with Ordered option #326

merged 1 commit into from
Apr 18, 2025

Conversation

chez-shanpu
Copy link
Contributor
@chez-shanpu chez-shanpu commented Apr 18, 2025

Some tests are expected to be tested in the order they are written, but the order of execution of It() is not determined.
Therefore order-sensitive tests was failing flaky.
e.g. https://github.com/cybozu-go/coil/actions/runs/14495849428/job/40663286944?pr=324

This PR add Ordered decoration to order-sensitive tests.

@chez-shanpu chez-shanpu requested a review from terassyi April 18, 2025 01:41
@chez-shanpu chez-shanpu force-pushed the e2e-ordered branch 2 times, most recently from f791dfe to 89ed053 Compare April 18, 2025 01:52
Signed-off-by: Tomoki Sugiura <tomoki-sugiura@cybozu.co.jp>
Copy link
Contributor
@terassyi terassyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chez-shanpu chez-shanpu merged commit 89546ff into main Apr 18, 2025
17 checks passed
@chez-shanpu chez-shanpu deleted the e2e-ordered branch April 18, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0