Add "bind_ip" config option #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affected functions / classes:
cybozu::make_server_socket
cybozu::tcp_server_socket
cybozu::setup_server_socket
This new option takes a space-separated list of IP addresses. If given, yrmcds will bind and listen on the IP addresses.
|
@nojima Please take a look. |
|
This PR also removes unncessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new config option "bind_ip".
bind_ip is a list of IP addresses to which yrmcds bind its sockets.
If bind_ip is empty, yrmcds continues to listen on all interfaces.
Close #63.