8000 Support generating PDF from web view's content by elmetal · Pull Request #58 · cybozu/WebUI · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support generating PDF from web view's content #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 7, 2025
Merged

Support generating PDF from web view's content #58

merged 15 commits into from
May 7, 2025

Conversation

elmetal
Copy link
Contributor
@elmetal elmetal commented Mar 26, 2025

No description provided.

@Yyilin001
Copy link

When can it be officially used?

@elmetal elmetal marked this pull request as ready for review April 21, 2025 06:36
@elmetal elmetal requested a review from Kyome22 as a code owner April 21, 2025 06:36
b1ackturtle
b1ackturtle reviewed Apr 21, 2025
View reviewed changes
Copy link
Collaborator
@b1ackturtle b1ackturtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the implementation. Could you please address the comments?

elmetal and others added 2 commits April 22, 2025 09:07
@elmetal @b1ackturtle
fix indentation
738511c 
Co-authored-by: b1ackturtle <ichibon0@gmail.com>
@elmetal @b1ackturtle
if let shorthand
29fd22f 
Co-authored-by: b1ackturtle <ichibon0@gmail.com>
Kyome22
Kyome22 reviewed Apr 22, 2025
View reviewed changes
Kyome22
Kyome22 reviewed Apr 22, 2025
View reviewed changes
Kyome22
Kyome22 reviewed Apr 22, 2025
View reviewed changes
Kyome22
Kyome22 reviewed Apr 22, 2025
View reviewed changes
Kyome22
Kyome22 reviewed Apr 22, 2025
View reviewed changes
Kyome22
Kyome22 reviewed Apr 22, 2025
View reviewed changes
Kyome22
Kyome22 reviewed Apr 22, 2025
View reviewed changes
Kyome22
Kyome22 reviewed Apr 22, 2025
View reviewed changes
elmetal and others added 3 commits April 23, 2025 09:15
@elmetal @Kyome22
omit return
ea991b4 
Co-authored-by: Takuto NAKAMURA (Kyome) <takuto-nakamura@cybozu.co.jp>
@elmetal @Kyome22
use nil-coalescing for clarity
127f62d 
Co-authored-by: Takuto NAKAMURA (Kyome) <takuto-nakamura@cybozu.co.jp>
@elmetal
include pdf state in ContentViewState
c183c77
elmetal
elmetal commented Apr 23, 2025
View reviewed changes
Kyome22
Kyome22 reviewed Apr 30, 2025
View reviewed changes
Kyome22
Kyome22 approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor
@Kyome22 Kyome22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Super Thanks!

@Kyome22 Kyome22 merged commit efc8e2a into main May 7, 2025
@Kyome22 Kyome22 deleted the generate-pdf-from-webview branch May 7, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b1ackturtle b1ackturtle b1ackturtle left review comments

@Kyome22 Kyome22 Kyome22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elmetal @Yyilin001 @b1ackturtle @Kyome22
0