8000 Fix crash when contact points of a PROTO are requested by lukicdarkoo · Pull Request #3522 · cyberbotics/webots · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix crash when contact points of a PROTO are requested #3522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 2, 2021
Merged

Fix crash when contact points of a PROTO are requested #3522

merged 9 commits into from
Aug 2, 2021

Conversation

lukicdarkoo
Copy link
Member

Fixes #3516

@lukicdarkoo lukicdarkoo added bug Something isn't working test suite Start the test suite labels Jul 29, 2021
@lukicdarkoo lukicdarkoo added this to the R2021c milestone Jul 29, 2021
@lukicdarkoo lukicdarkoo self-assigned this Jul 29, 2021
@lukicdarkoo lukicdarkoo marked this pull request as ready for review July 30, 2021 08:09
@lukicdarkoo lukicdarkoo requested review from a team and stefaniapedrazzi July 30, 2021 08:09
@stefaniapedrazzi
Copy link
Member

It would be good to add a test for this issue in the test suite in order to prevent regressions.

stefaniapedrazzi
stefaniapedrazzi previously approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member
@stefaniapedrazzi stefaniapedrazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stefaniapedrazzi stefaniapedrazzi modified the milestones: R2021c, R2021c-rev1 Aug 2, 2021
ad-daniel
ad-daniel reviewed Aug 2, 2021
View reviewed changes
Copy link
Contributor
@ad-daniel ad-daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor

@lukicdarkoo @ad-daniel
Update tests/api/controllers/center_of_mass_and_contact_points/center…
ed06d9c 
…_of_mass_and_contact_points.c

Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>
@lukicdarkoo lukicdarkoo requested a review from ad-daniel August 2, 2021 10:10
ad-daniel
ad-daniel approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor
@ad-daniel ad-daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@lukicdarkoo lukicdarkoo merged commit 7b82e25 into master Aug 2, 2021
@lukicdarkoo lukicdarkoo deleted the fix-contact-points-proto branch August 2, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ad-daniel ad-daniel ad-daniel approved these changes

@stefaniapedrazzi stefaniapedrazzi stefaniapedrazzi left review comments

Assignees

@lukicdarkoo lukicdarkoo

Labels
bug Something isn't working test suite Start the test suite
Milestone
R2021b-rev1
Development

Successfully merging this pull request may close these issues.

The wb_supervisor_node_get_contact_points crashes a controller in certain cases
3 participants
@lukicdarkoo @stefaniapedrazzi @ad-daniel
0