Update Turkish #69
Update Turkish #69
Conversation
|
I greatly appreciate the effort you put into this, but as is it is unreviewable.
Examples:
|
|
@edgan Alright then, I'll try to remove fixed words and those marked as "translatable=false". I also didn't understand which part you need me to review - I tried to follow the proper XML format throughout, so it shouldn't cause any build errors. Secondly, I know this is a fork, and I couldn't figure out why the strings in the main application are so different. When I checked your application, I found some Turkish sections, but I couldn't match them with the strings in your current Turkish file or the strings in the repository you forked. |
|
And also yes, I just noticed that the quotation marks were in the previous language file. This is strange and something I've never seen before. I couldn't see this because I translated from the English file. If this is required, I can edit it again by adding the quotation marks. |
|
I haven't touched any of the translation files from |
It works with or without the quotes. With quotes is just the current state of the Better diff: Bad diff: |
|
Just start over with If I took this existing pull request, as is, I have two choices. Take it completely on faith that you did a good job or put in a ton of work reviewing every single line. This is also made much worse, because I don't speak Turkish. So I am going to have to lean on translation services, and then just make a judgement call. It also doesn't help that I don't know you at all, or your reputation. I am not trying to imply anything, just admitting my own ignorance when it comes to you, and how that informs my decision. |
Thank you for your feedback and for pointing out the issues with the PR size and translations. I’ve been translating for various projects as a hobby for several years and have experience as a proofreader on Crowdin, so I’m confident in the quality of these Turkish translations. Given that the app’s translations often come from random contributors, this PR aims to fill in the missing strings, and I don’t see major issues with the current ones. I’d prefer to keep this as a single PR since splitting it might complicate consistency, and aligning the Turkish file closely with the English one makes future updates easier for me or others. That said, I’m open to reviewing specific sections together to address any concerns and build trust in the translations—please let me know how you’d like to proceed. |
|
Besides that, if you want send me a test apk file created with this translation file, so I can examine it and let you know if there are any issues. |
I get your perspective too. One of the first bad signs was when I clicked on the Can you link me to other translation work you have done? Again I am not saying anything about the quality of your translations, but see this @mikropsoft Instead of going back and forth like this via |
I have placed my translation project records at the bottom of my GitHub page. Among these are projects I've translated through Crowdin as well. https://crowdin.com/profile/mikropsoft is my Crowdin address. Speaking of which, if you're going to focus on translations, I recommend creating a Crowdin project. As you mentioned, this will at least eliminate the commit issue and make things simpler for you. If you examine my translation projects, you'll see there are projects with over 1,500 lines (most of these are available on Crowdin). And yes, you cannot view the changes through the mobile application. Besides that, the reason I did the translation was because the application strings didn't match with Infinity x Reddit, resulting in the application being completely devoid of Turkish. And as I mentioned before, if you can create a test APK for me, I can test it for you and fix any errors (also, submitting the file to any AI model for checking would be simpler than you checking it yourself). Additionally, I'd like to note that I don't have and don't use a Discord account. Instead, you can provide your Telegram address if you have one. |
I was able to review this application just now. If you'd like, I can also make edits for the translation of this. |
|
I misspoke before. I have changed the file. Either to remove strings that are no longer needed, or to change things that aren't translation related. These were done with search replace. All changes to |
Synced with english