Delayed message body loading 8000 #904
Conversation
|
@cytopia, just checking in to see if you have notifications setup for PRs and saw this. Again, I'm happy to accomplish this goal a different way if you'd prefer. |
|
@mmcev106 unfortunately this currently breaks the integration tests here: https://github.com/cytopia/devilbox/blob/master/.tests/tests/intranet-email.sh#L72-L74 Do you have an idea, how to rewrite them and still make sure it tests for successful mail delivery? |
|
@cytopia, I just pushed a commit that should fix that test script. Let m 8000 e know if you need anything else! |
|
Would you like me to fix the PHP 5.3 test failures, or perhaps limit testing to PHP 7+? |
|
Yes please. The intranet is supposed to work from PHP 5.3 onwards (5.2 is currently available, but not supported via the intranet) |
|
Accidentally closed 🤦 now the checks are running from scratch :-/ |
|
Done! However, you might want to consider dropping support for very old PHP versions. PHP has not supported 5.3 for eight years now. |
Delayed message body loading
Goal
The Mail page was crashing for me because I had a lot of large emails that were more than the browser could load at once. This PR fixes that problem by delaying message body loading until each message is clicked to reveal the body (which is now loaded via AJAX). I'm happy to do this a different way if you'd prefer.
DESCRIPTION
Not much else to say...