nixconf: fix handling of optional !include statements
#694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optional includes would throw an error if the file was missing. The issue was that the check handling missing/required files did not implement all of the branches correctly. Instead of first checking the file and then reading it, we now read the file and handle the errors after the fact. This makes the logic easier to understand at a glance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional includes would throw an error if the file was missing.
The issue was that the check handling missing/required files did not
implement all of the branches correctly.
64febd2 - fixes the logic and adds a test case.
03e9576 - dedupes the parsing and error handling logic.
Fixes #693.