8000 Use Deno EventEmitter polyfill by auxves · Pull Request #66 · cacjs/cac · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

8000 Use Deno EventEmitter polyfill #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 6, 2020
Merged

Use Deno EventEmitter polyfill #66

merged 3 commits into from
Mar 6, 2020

Conversation

auxves
Copy link
Contributor
@auxves auxves commented Mar 6, 2020

This fixes importing CAC in Deno since the events module doesn't exist there.

@egoist
Copy link
Collaborator
egoist commented Mar 6, 2020

don't edit mod.js it's auto-generated, we should update rollup to inline events module: https://github.com/cacjs/cac/blob/master/rollup.config.js

@codecov-io
Copy link
codecov-io commented Mar 6, 2020 •
edited
Loading

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   66.93%   66.93%           
=======================================
  Files           6        6           
  Lines         369      369           
  Branches       85       91    +6     
=======================================
  Hits          247      247           
  Misses        119      119           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809db10...ba05af4. Read the comment docs.

@auxves
Copy link
Contributor Author
auxves commented Mar 6, 2020

@egoist I have updated the rollup config, now it replaces events with the Deno URL automatically.

egoist
egoist reviewed Mar 6, 2020
View reviewed changes
rollup.config.js Outdated
if (id === 'events') {
return [
'export { default } from "https://deno.land/std/node/events.ts"',
'export * from "https://deno.land/std/node/events.ts"'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess export * will export default as well

@egoist egoist merged commit aa8f868 into cacjs:master Mar 6, 2020
@egoist
Copy link
Collaborator
egoist commented Mar 6, 2020

🎉 This PR is included in version 6.5.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@egoist egoist added the released label Mar 6, 2020
@auxves auxves deleted the patch-1 branch March 6, 2020 15:28
@vibegui vibegui mentioned this pull request Mar 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egoist egoist egoist left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@auxves @egoist @codecov-io
0