fix issue #37 regarding method location #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fix this error AttributeError: 'NoneType' object has no attribute 'promotePrefixes'
|
Worked for me! Thanks! |
drice
reviewed
Sep 9, 2019
| @@ -729,7 +728,7 @@ def failed(self, binding, error): | |||
|
|
|||
| def location(self): | |||
| p = Unskin(self.options) | |||
| return p.get('location', self.method.location) | |||
| return p.get('location', self.method.location.decode('utf-8')) | |||
There was a problem hiding this comment.
it is the same as utf-8 is the default encoding as stated in python3 docs
|
what exactly should I write in my project's requirements.txt file to be able to install this pull request instead of "suds-py3==1.3.3.0"? |
|
requirements.txt |
|
Thank you very much, I had changed it manually and replaced it with what you said, worked! |
lsaffre
added a commit
to lino-framework/welfare
that referenced
this pull request
Oct 2, 2019
|
Thanks for this. I had the same issue and could fix it as explained here. |
|
merge this bb |
hatchjdecho
added a commit
to hatchjdecho/suds-py3
that referenced
this pull request
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this issue happens when the method location/url is different to wsdl location/url.
suds client always takes the wsdl location/url and not the method location so when making a request it uses wrong location getting invalid response hence causing this issue.
by the way suds python2 library doesn't have line 107 therefore it works fine.