Added float types and float slices #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caarlos0
requested changes
Oct 13, 2016
| Float32 float32 `env:"FLOAT32"` | ||
| Float64 float64 `env:"FLOAT64"` | ||
| Float32s []float32 `env:"FLOAT32S"` | ||
| Float64s []float64 `env:"FLOAT64S"` |
There was a problem hiding this comment.
DOH! Of course! Let me get that. Thanks for catching!
|
Thanks! |
|
👍 Very helpful! |
|
No problem. Glad to help! |
nexoscp
added a commit
to nexoscp/env
that referenced
this pull request
Apr 7, 2022
Added float types and float slices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
We found that in our project we really wanted to represent floats in our env config. Therefore, here's a pull request to do just that. I implemented both float32 and float64 in addition to slice types. Unit tests and readme updated. Thanks!