refactor: remove testify #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Removes the testify dependency and replaces require assertions with standard library testing calls.
- Replaced
require.*calls in tests withifchecks andt.Fatalf - Removed
github.com/stretchr/testify(and other unused test deps) fromgo.mod - Updated test imports to drop
require
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| levels_test.go | Replaced require.NoError/Equal with manual if+t.Fatalf |
| entry_test.go | Swapped out require calls for standard testing checks |
| context_test.go | Removed require, updated to use if+t.Fatalf |
| go.mod | Dropped testify and other indirect test-related modules |
Comments suppressed due to low confidence (1)
context_test.go:11
- The test uses
context.Background()but thecontextpackage isn't imported, causing a compilation error. Please addimport "context".
ctx := context.Background()
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
=======================================
Coverage 79.83% 79.83%
=======================================
Files 6 6
Lines 238 238
=======================================
Hits 190 190
Misses 44 44
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use only the std lib instead