feat: use lipgloss/v2 #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
=======================================
Coverage 78.26% 78.26%
=======================================
Files 5 5
Lines 207 207
=======================================
Hits 162 162
Misses 42 42
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR replaces direct usage of Lip Gloss v1 and Termenv with Charm’s ColorProfile wrapper and updates to Lip Gloss v2, modernizes API signatures, and adjusts test expectations to the new ANSI reset code.
- Wraps the logger’s writer in
colorprofile.NewWriterand bumps dependencies tolipgloss/v2. - Replaces
interface{}with Go 1.18’sanyin public APIs. - Updates golden test outputs to use
\x1b[mreset and sets color environment variables in tests.
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testdata/*.golden | Updated ANSI reset code from \x1b[0m to \x1b[m. |
| pkg_test.go | Removed Lip Gloss init, set color env vars, refactored loop. |
| pkg.go | Added colorprofile.NewWriter; changed interface{} → any. |
| logger.go | Switched to *colorprofile.Writer; imported lipgloss/v2. |
| entry.go | Replaced interface{} with any in entry methods. |
| go.mod | Bumped Go version, switched dependencies to colorprofile & Lip Gloss v2. |
Comments suppressed due to low confidence (1)
pkg_test.go:46
- Invalid loop syntax
for range 9999 {}. To run 9,999 goroutines, revert tofor i := 0; i < 9999; i++ {or usefor range [9999]struct{} {}.
for range 9999 {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.