Update from upstream repo #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update image used for CircleCI
Change purge-forms script to general purge
Resolves warnings:
- FromAsCasing: 'as' and 'FROM' keywords' casing do not match
This script is no longer used anywhere.
Release v2024.2
These assertions are followed by more specific assertions on res.status, which provide more helpful error messages on failure.
Don't fail log output build steps if the corresponding docker image never started, e.g.
Error response from daemon: No such container: test-enketo-1
This makes the github actions GUI less confusing and quicker to navigate to the real build failure.
pros: * nginx tests actually run against a real image cons: * slows fresh/CI builds by about 1 minute
* this path isn't relevant to these tests, as they do not use letsencrypt SSL certs * the tests don't make sense, as they're checking for 404s * in the test scenario, specific handling for this path is removed from redirector.conf in files/nginx/setup-odk.sh
Release v2024.2.1
QR displayed in odk-central-frontend are displayed with src=data:... Closes getodk#629
Removed from backend codebase in getodk/central-backend#1293
This significantly decreases test turnaround time. Local results (`./run-tests; time ./run-tests.sh`): * with this PR: 14 seconds * without this: 90 seconds Cons: * complicates build script (`build-frontend.sh`)
Nginx server config: JS was not compressed
Working on getodk#809 I noticed that the location of SSL certs is based either on the domain name, or on the method of supply of SSL certs. Cert provision approach should probably not affect the nginx "server_name" setting. Also, the old variable name `CNAME` (short for "certificate name?") is easily confused with the DNS concept of CNAME records ("canonical names").
Co-authored-by: alxndrsn <alxndrsn>
* Use node 22.12.0 Docker images * Upgrade Enketo * Fix dependency vulnerabilities * Use pyxform 3.0.0
This comment was merged as part of getodk#809, but was not correct by the time the PR was merged.
added outdated-version.html
Release v2024.3
tobiasmcnulty
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges in changes from the master branch on the upstream repo. There were some merge conflicts in
files/service/scripts/start-odk.shandfiles/nginx/setup-odk.sh