8000 fix(codeScan): optimize code scan by zhujian7 · Pull Request #647 · caicloud/cyclone · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(codeScan): optimize code scan #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Conversation

zhujian7
Copy link
Collaborator
@zhujian7 zhujian7 commented Dec 5, 2018
  • validate token while adding integration
  • get sonarqube project quality gate details
  • find java binaries in the workspace, then set it to sonar
  • find go test cover profile, then set it to sonar
  • find java JUnit test file, then set it to sonar
  • set default value of sonar sources to '.'
  • wait sonar compute engine to complete background task, then to get scan results
  • create sonar project and set quality gate while creating the pipeline

What this PR does / why we need it:

Add your description

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @supereagle @cd1989 @qiuxiaolian

Release note:

NONE

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 5, 2018
@zhujian7 zhujian7 force-pushed the sonar branch 2 times, most recently from d6328d2 to 9702e89 Compare December 5, 2018 14:54
- validate token while add integration
- get sonarqube project quality gate details
- find java binaries in workspace, then set it to sonar
- find go test cover profile, then set it to sonar
- find java junit test file, then set it to sonar
- set default value of sonar sources to '.'
- wait sonar compute engine to complete backgroud task, then to get scan results
- create sonar project and set quality gate while create pipeline
@cd1989
Copy link
Contributor
cd1989 commented Dec 6, 2018

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2018
@caicloud-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cd1989

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2018
@caicloud-bot caicloud-bot merged commit a9b1fe8 into caicloud:master Dec 6, 2018
@zhujian7 zhujian7 deleted the sonar branch February 14, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0