8000 fix(validate): comment out validate-prop change checker of field by caosm · Pull Request #3 · caicloud/redux-form · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(validate): comment out validate-prop change checker of field #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2018
Merged

fix(validate): comment out validate-prop change checker of field #3

merged 1 commit into from
Aug 16, 2018

Conversation

caosm
Copy link
@caosm caosm commented Apr 26, 2018

What this PR does / why we need it:

  • 注释掉 Field 的 validate prop 的变化检查，以解决已有表单验证失败的问题

Which issue(s) this PR fixes (optional, close the issue(s) when PR gets merged):

Fixes #

Special notes for your reviewer:

/cc @your-reviewer

Release note:

NONE

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 26, 2018
@caicloud-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@caicloud-bot caicloud-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 2, 2018
xu-ai-liang
xu-ai-liang reviewed Aug 15, 2018
View reviewed changes
Copy link
@xu-ai-liang xu-ai-liang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2018
@caosm
Copy link
Author
caosm commented Aug 16, 2018

/approve

@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caosm, xu-ai-liang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

Assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caosm caosm merged commit bf0e26d into caicloud:caicloud-7.2.1 Aug 16, 2018
caosm added a commit that referenced this pull request Mar 18, 2019
@caosm
fix(validate): comment out validate-prop change checker of field (#3)
91cf4ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xu-ai-liang xu-ai-liang xu-ai-liang left review comments

Assignees

@xu-ai-liang xu-ai-liang

Labels
caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caosm @caicloud-bot @xu-ai-liang
0