8000 feat: extract node ui code by frdomovic · Pull Request #1252 · calimero-network/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: extract node ui code #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
May 19, 2025
Merged

feat: extract node ui code #1252

merged 29 commits into from
May 19, 2025

Conversation

frdomovic
Copy link
Member
@frdomovic frdomovic commented May 8, 2025 •
edited
Loading

feat: extract node ui code

Description

As part of this issue removing all files and logic (workflows, scripts) connected to node-ui. Node-ui will instead be downloaded from admin-dashboard.

Test plan

Manually testing building with node with cargo run -p merod -- --node-name node1 init --server-port 2428 --swarm-port 2528 and cargo run -p merod -- --node-name node1 run and opening localhost:2428/admin-dashboard/ in browser.

Documentation update

-> No need for update as building the node-ui project is never mentioned source

@frdomovic frdomovic self-assigned this May 8, 2025
miraclx
miraclx reviewed May 9, 2025
View reviewed changes
@frdomovic frdomovic marked this pull request as ready for review May 9, 2025 14:59
miraclx
miraclx reviewed May 9, 2025
View reviewed changes
miraclx
miraclx reviewed May 13, 2025
View reviewed changes
Copy link
Member
@miraclx miraclx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're also missing CALIMERO_WEB_UI_FETCH, and while cached_path doesn't currently support forced download even with a cache-hit, I filed epwalsh/rust-cached-path#80

and the maintainer has already implemented the patch, you can use that branch to test it out by adding this to the root manifest

[patch.crates-io]
cached-path = { git = "https://github.com/epwalsh/rust-cached-path.git", branch = "epwalsh/force-download" }

@frdomovic frdomovic force-pushed the feat-extract-node-ui-code branch from 914bab2 to 027e7b0 Compare May 14, 2025 11:11
@frdomovic
Copy link
Member Author

Ran tests 2 times and failing clippy is now passing, not sure about the build cc @miraclx @alenmestrov

miraclx
miraclx reviewed May 16, 2025
View reviewed changes
Copy link
Member
@miraclx miraclx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cached-path v0.7.0 has been released with the forced download option.

@frdomovic
Copy link
Member Author

println!("cargo:rerun-if-changed={}", src);

@github-actions GitHub Actions
Copy link

E2E tests report

Scenario: ethereum

Protocol/Step 0. app install (AllMembers) 1. ctx create 2. ctx invite-join 3. wait (Consensus) 4. call (create_new_proposal, Inviter) 5. get proposals 6. call (send_proposal_messages, Inviter) 7. wait (Broadcast) 8. call (get_proposal_messages, Invitees) 9. call (approve_proposal, Invitees) 10. verify external state
ethereum ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅

Scenario: icp

Protocol/Step 0. app install (AllMembers) 1. ctx create 2. ctx invite-join 3. wait (Consensus) 4. call (create_new_proposal, Inviter) 5. get proposals 6. call (send_proposal_messages, Inviter) 7. wait (Broadcast) 8. call (get_proposal_messages, Invitees) 9. call (approve_proposal, Invitees) 10. verify external state
icp ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅

Scenario: near

Protocol/Step 0. app install (AllMembers) 1. ctx create 2. ctx invite-join 3. wait (Consensus) 4. call (create_new_proposal, Inviter) 5. get proposals 6. call (send_proposal_messages, Inviter) 7. wait (Broadcast) 8. call (get_proposal_messages, Invitees) 9. call (approve_proposal, Invitees) 10. verify external state
near ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅

Scenario: stellar

Protocol/Step 0. app install (AllMembers) 1. ctx create 2. ctx invite-join 3. wait (Consensus) 4. call (create_new_proposal, Inviter) 5. get proposals 6. call (approve_proposal, Invitees) 7. verify external state 8. call (create_new_proposal, Inviter) 9. get proposals 10. call (send_proposal_messages, Inviter) 11. wait (Broadcast) 12. call (get_proposal_messages, Invitees)
stellar ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅

@miraclx miraclx mentioned this pull request May 19, 2025
Open
@miraclx miraclx force-pushed the feat-extract-node-ui-code branch from cfddb0a to cd9624d Compare May 19, 2025 04:19
@miraclx miraclx changed the base branch from master to miraclx/pull-node-ui-on-build May 19, 2025 04:20
@miraclx miraclx force-pushed the feat-extract-node-ui-code branch from cd9624d to d01e133 Compare May 19, 2025 04:47
@frdomovic frdomovic merged commit 6deb2db into miraclx/pull-node-ui-on-build May 19, 2025
2 checks passed
@frdomovic frdomovic deleted the feat-extract-node-ui-code branch May 19, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miraclx miraclx miraclx approved these changes

@alenmestrov alenmestrov Awaiting requested review from alenmestrov

@fbozic fbozic Awaiting requested review from fbozic

Assignees

@frdomovic frdomovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frdomovic @miraclx
0