8000 Update osv-scanner.yml by canstralian · Pull Request #12 · canstralian/geminiCoder · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update osv-scanner.yml #12 8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2025
Merged

Update osv-scanner.yml #12

merged 1 commit into from
Feb 8, 2025

Conversation

canstralian
Copy link
Owner
@canstralian canstralian commented Feb 2, 2025 •
edited by sourcery-ai bot
Loading

Summary by Sourcery

CI:

  • Update OSV-Scanner action to always use the latest version.

@canstralian canstralian self-assigned this Feb 2, 2025
@sourcery-ai Sourcery AI
Copy link
sourcery-ai bot commented Feb 2, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request updates the osv-scanner workflow to use the latest version of the reusable workflows and removes the comment about the action not being certified by GitHub.

Flow diagram of updated OSV-Scanner GitHub Actions workflow

graph TD
    A[Push/Schedule Event] --> B{Event Type?}
    B -->|Push/Schedule| C[scan-scheduled job]
    B -->|PR/Merge Group| D[scan-pr job]
    C -->|Uses| E[osv-scanner-reusable.yml@main]
    D -->|Uses| F[osv-scanner-reusable-pr.yml@main]
    E --> G[Scan with args:
-r
--skip-git
./]
    F --> H[Scan with args:
-r
--skip-git
./]
Loading

File-Level Changes

Change Details Files
Update reusable workflow versions to use the latest version
  • Updated the reusable workflow version for scheduled scans to use the latest version.
  • Updated the reusable workflow version for pull request scans to use the latest version.
 .github/workflows/osv-scanner.yml
Removed the comment about the action not being certified by GitHub
  • Removed the comment at the beginning of the file.
 .github/workflows/osv-scanner.yml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot requested changes Feb 2, 2025
View reviewed changes
Copy link
@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @canstralian - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Avoid using '@main' reference - pin to specific commit hash for security (link)

Overall Comments:

  • Using @main instead of a pinned version for the OSV scanner action is a security risk. Please specify a fixed version (like v1.7.1) to ensure reproducible and secure builds.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🔴 Security: 1 blocking issue
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@canstralian canstralian merged commit 43647b7 into main Feb 8, 2025
9 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] requested changes

Assignees

@canstralian canstralian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@canstralian
0