8000 Fix CI by andlaus · Pull Request #719 · cantools/cantools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix CI #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Fix CI #719

merged 5 commits into from
Jan 15, 2025

Conversation

andlaus
Copy link
Member
@andlaus andlaus commented Jan 15, 2025

the CI system recently started failing on us:

  • A new version of ruff has been released which seems to complain about naming conflicts between custom submodules and standard python modules. We disable that check because renaming signal.py would probably leave a path of destruction in user code.
  • pypy currently seems to be unable to install the (indirect) "pillow" dependency. For this reason, we disable testing using pypy for now...

Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information

This checks if a submodule name shadows a Python standard-library
module.  This happens for cantools' signal submodule.

Signed-off-by: Andreas Lauser <andreas.lauser@mercedes-benz.com>
Signed-off-by: Gerrit Ecke <gerrit.ecke@mercedes-benz.com>
this recently started failing on us due to some dependency failing to
be installed.

Signed-off-by: Andreas Lauser <andreas.lauser@mercedes-benz.com>
Signed-off-by: Gerrit Ecke <gerrit.ecke@mercedes-benz.com>
@andlaus andlaus requested a review from zariiii9003 January 15, 2025 09:52
@andlaus
Copy link
Member Author
andlaus commented Jan 15, 2025

@zariiii9003: would be great if you knew a way to get pypy working again instead of disabling it...

@zariiii9003
Copy link
Collaborator

Pillow does not build wheels for 3.9 anymore. I'd try pypy-3.10 🤷‍♂️

Signed-off-by: Andreas Lauser <andreas.lauser@mercedes-benz.com>
@coveralls
Copy link
coveralls commented Jan 15, 2025

Pull Request Test Coverage Report for Build 12786329837

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on fix_ci at 93.567%

Totals Coverage Status
Change from base Build 12774919741: 93.6%
Covered Lines: 7287
Relevant Lines: 7788

💛 - Coveralls

@andlaus
Copy link
Member Author
andlaus commented Jan 15, 2025

Pillow does not build wheels for 3.9 anymore. I'd try pypy-3.10 🤷‍♂️

ok: pypi-3.10 seems to work with pillow on windows, but it bails out due to some other reason which I could not grok from the error message. I disabled testing with pypy on windows, i.e., pypy is still tested on ubuntu...

@zariiii9003
Copy link
Collaborator

It seems like there's something missing in the matplotlib wheel for pypy...

@andlaus
Copy link
Member Author
andlaus commented Jan 15, 2025

can we fix this on our side? if not, let's just disable that config; After all, pypy and windows are still tested, just not both together...

Signed-off-by: Andreas Lauser <andreas.lauser@mercedes-benz.com>
Signed-off-by: Andreas Lauser <andreas.lauser@mercedes-benz.com>
@andlaus andlaus merged commit d7fa49b into cantools:master Jan 15, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0