8000 feat: add useIdAsName field for WeCom OAuth provider by dacongda · Pull Request #3797 · casdoor/casdoor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add useIdAsName field for WeCom OAuth provider #3797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

feat: add useIdAsName field for WeCom OAuth provider #3797

merged 1 commit into from
May 16, 2025

Conversation

dacongda
Copy link
Contributor
@dacongda dacongda commented May 16, 2025 •
edited by hsluoyz
Loading

Fix: #3780

@dacongda
Copy link
Contributor Author

@Rocky-Jinxing can you help me test this pr?

@Rocky-Jinxing
Copy link

can you help me test this pr?

Sure, it's late at night now, I can help you test it during the day tomorrow.

@hsluoyz hsluoyz changed the title feat: add Use id as name option for wecom provider feat: add useIdAsName field for WeCom OAuth provider May 16, 2025
@hsluoyz hsluoyz merged commit 4260efc into casdoor:master May 16, 2025
8 checks passed
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 1.910.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Rocky-Jinxing
Copy link

@Rocky-Jinxing can you help me test this pr?

@dacongda
I saw that it has been released. My casdoor docker has been upgraded to v1.910.0. Regardless of whether my casdoor user has an account with name=renjinxing, the name of casdoor is always randomly generated after logging in with wocom.

And I also tested that I already have an account with name=renjinxing in casdoor. After logging in with this account, I can manually bind a third party to log in to wecom.
image
image
image

image
image
image

@dacongda
Copy link
Contributor Author

@Rocky-Jinxing can you help me test this pr?

@dacongda I saw that it has been released. My casdoor docker has been upgraded to v1.910.0. Regardless of whether my casdoor user has an account with name=renjinxing, the name of casdoor is always randomly generated after logging in with wocom.

And I also tested that I already have an account with name=renjinxing in casdoor. After logging in with this account, I can manually bind a third party to log in to wecom. image image image

image image image

you should open use id as name option in wecom provider

@dacongda
Copy link
Contributor Author

QQ_1747475015067

@Rocky-Jinxing
Copy link

@dacongda
Thank you very much, I have tested it.

  1. When there is no user with name=RenJinXing in casdoor, the application opens registration, the user successfully registers by scanning the wecom code, and name=RenJinXing.

  2. When there is a user with name=RenJinXing in casdoor, the application opens registration, the user successfully registers by scanning the wecom code, and name=RenJinXing_621e, 621e is randomly generated.

  3. When there is a user with name=RenJinXing in casdoor, the application does not open registration, the user fails to log in by scanning the wecom code, and an error message is given (The account for provider: WeCom and username: RenJinXing (任金星) does not exist and is not allowed to sign up as new account, please contact your IT support
    )

For 1 and 2, there is no problem at all, but for 3, there is actually a user with name=RenJinXing in casdoor. Can the application bind him to the existing account without opening registration? Otherwise, enterprise users can only manually bind in user information after successful login.

@dacongda dacongda deleted the feat/3780 branch May 17, 2025 10:37
@dacongda
Copy link
Contributor Author

@dacongda Thank you very much, I have tested it.

  1. When there is no user with name=RenJinXing in casdoor, the application opens registration, the user successfully registers by scanning the wecom code, and name=RenJinXing.
  2. When there is a user with name=RenJinXing in casdoor, the application opens registration, the user successfully registers by scanning the wecom code, and name=RenJinXing_621e, 621e is randomly generated.
  3. When there is a user with name=RenJinXing in casdoor, the application does not open registration, the user fails to log in by scanning the wecom code, and an error message is given (The account for provider: WeCom and username: RenJinXing (任金星) does not exist and is not allowed to sign up as new account, please contact your IT support
    8000 )

For 1 and 2, there is no problem at all, but for 3, there is actually a user with name=RenJinXing in casdoor. Can the application bind him to the existing account without opening registration? Otherwise, enterprise users can only manually bind in user information after successful login.

for 3, maybe we can add a extra option named "auto bind to exist user", you can open a new issue to discuss it.

@Rocky-Jinxing
Copy link

I have re-created the issue #3801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wecom scan code login, Casdoor did not obtain Wecom userid
3 participants
@dacongda @Rocky-Jinxing @hsluoyz
0