8000 Add `COMPONENT_SEPARATOR` and `PATH_SEPARATOR` constants by casey · Pull Request #2679 · casey/just · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add COMPONENT_SEPARATOR and PATH_SEPARATOR constants #2679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add COMPONENT_SEPARATOR and PATH_SEPARATOR constants #2679

wants to merge 5 commits into from

Conversation

casey
Copy link
Owner
@casey casey commented Mar 24, 2025

See #2314 (comment).

@cspotcode, what do you think of the naming here? / is the COMPONENT_SEPARATOR, because it separates components, ; is the PATH_SEPARATOR, because it separates paths.

I want to keep the names short. We could also go with COMPONENT_SEP and PATH_SEP, although that is pretty incomprehensible.

@cspotcode
Copy link

Yeah, any of those options work for me: COMPONENT_SEPARATOR, COMPONENT_SEP, DIR_SEP.

@casey
Copy link
Owner Author
casey commented Mar 24, 2025

I changed the name to PATH_SEP and PATH_VAR_SEP. Kinda wanna let this sit for a second in case anyone has any feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casey @cspotcode
0