Update for hcl tags #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors and extends the tagging logic in the
queries/hcl/tags.scmfile to improve the handling of HCL block types. The changes include reordering and refining block definitions, reintroducinglocalsandterraformblock types, and adding a fallback for generic blocks.Refinements to block type handling:
resourceblock definition to replace the generic block capture for better specificity. ([queries/hcl/tags.scmL5-R6](https://github.com/cased/kit/pull/1/files#diff-c49dc889037c2834bee19fb36e2db1389b11c22fd5f5c070a51652d4713f6da4L5-R6))Reintroduction of specific block types:
localsblock type with updated positioning and logic for better clarity and organization. ([queries/hcl/tags.scmR43-R57](https://github.com/cased/kit/pull/1/files#diff-c49dc889037c2834bee19fb36e2db1389b11c22fd5f5c070a51652d4713f6da4R43-R57))terraformblock type to explicitly handle Terraform-specific blocks. ([queries/hcl/tags.scmR43-R57](https://github.com/cased/kit/pull/1/files#diff-c49dc889037c2834bee19fb36e2db1389b11c22fd5f5c070a51652d4713f6da4R43-R57))Fallback for generic block handling:
[queries/hcl/tags.scmR43-R57](https://github.com/cased/kit/pull/1/files#diff-c49dc889037c2834bee19fb36e2db1389b11c22fd5f5c070a51652d4713f6da4R43-R57))Removal of outdated logic:
localsblock capture logic, replacing it with the updated and more flexible version. ([queries/hcl/tags.scmL21-L26](https://github.com/cased/kit/pull/1/files#diff-c49dc889037c2834bee19fb36e2db1389b11c22fd5f5c070a51652d4713f6da4L21-L26))