This repository was archived by the owner on Jun 19, 2020. It is now read-only.
Fix dotnet test #1388
Merged
Fix dotnet test #1388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don’t try to make absolute path to engine executable in the casperjs directory. See #1386.
|
Looks good; however this could actually only be tested on a windows platform (so no chance to check the difference in CI, see travis-ci/travis-ci#216). |
|
I have tested it on actual Windows 10, but the mono approach seems to work, too. The CL option problem I found failed on both and is now fixed on both. |
|
Contains the change set of #1387. |
|
Looks ok; @paazmaya, @hexid, @mickaelandrieu, @n1k0 please give a second opinion and/or merge. Merge this before #1389. |
|
Ping @hexid; could you please have a look at this and possibly merge it if it's okay for you? Thanks a bunch. |
|
Looks good to me. @mepard Thanks for the fix |
Sign up for free
to subscribe to this conversation on GitHu
5D28
b.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move addition of mono from Makefile to runtests.py. Fixes #1385.