8000 Fix XUnit output with Gecko by laurentj · Pull Request #754 · casperjs/casperjs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 19, 2020. It is now read-only.

Fix XUnit output with Gecko #754

Closed
wants to merge 2 commits into from
Closed

Fix XUnit output with Gecko #754

wants to merge 2 commits into from

Conversation

laurentj
Copy link
Contributor
@laurentj laurentj commented Dec 8, 2013

The toString() function is not called by gecko because a DOMNode does not inherits from Object. We should call a specific function to serialize the content of the XML.

Closes #753

@laurentj
Fix XUnit output with Gecko
1d39d55 
the toString() function is not called by gecko because a DOMNode
does not inherits from Object. We should call a specific function
to serialize the content of the XML.

Closes #753
@laurentj
oups, forgot to delete debug code
6e85628
@n1k0
Copy link
Member
n1k0 commented Dec 8, 2013

Strangely it always fails when using the .NET executable… No idea why. Also, I think we should add a python cli test to check for the resulting XML file creation.

@hexid
Copy link
Collaborator
hexid commented Dec 8, 2013

I'll take a look at this tomorrow to see if it's an issue with the .NET launcher
Sorry I've been kind of inactive lately, but I've been pretty busy with school this past month.

@n1k0
Copy link
Member
n1k0 commented Dec 8, 2013

@hexid no pb

@hexid
Copy link
Collaborator
hexid commented Dec 9, 2013

Ok, I found the issue. If you check the travis builds, the builds that passed do in fact have the failed tests.

I got it working by changing the lines in tests/suites/xunit.js from:

casper.start().setContent(xunit.getXML());

to:

casper.start().setContent(xunit.getSerializedXML());

@hexid
Copy link
Collaborator
hexid commented Dec 9, 2013

This also brings up an issue about the test suite not returning the correct exit code when using the python launcher.
8000

@n1k0
Copy link
Member
n1k0 commented Dec 9, 2013

@hexid indeed! that's really weird.

@laurentj could you please update your PR according to @hexid's suggested changes? Also, please rebase to get rid of the oups commit ;)

@hexid hexid mentioned this pull request Dec 10, 2013
Merged
@n1k0
Copy link
Member
n1k0 commented Dec 10, 2013

Will update the PR, see #759

n1k0 added a commit that referenced this pull request Dec 10, 2013
@n1k0
Merge pull request #759 from n1k0/fix-gecko-unit
57c4192 
Fix XUnit output with Gecko (@laurentj) - closes #753 #754
@n1k0 n1k0 closed this Dec 12, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurentj @n1k0 @hexid
0