8000 Add style.display check for inline-block when determining element visibility by tohann · Pull Request #855 · casperjs/casperjs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 19, 2020. It is now read-only.

Add style.display check for inline-block when determining element visibility #855

Merged
merged 1 commit into from
Mar 10, 2014
Merged

Add style.display check for inline-block when determining element visibility #855

merged 1 commit into from
Mar 10, 2014

Conversation

tohann
Copy link
Contributor
@tohann tohann commented Mar 10, 2014

When checking for visibility, style.display is checked to match “inline”. Added a check for “inline-block”.

@n1k0
Copy link
Member
n1k0 commented Mar 10, 2014

Thanks. Adding a test would be really nice :)

@n1k0 n1k0 added Bug labels Mar 10, 2014
@tohann
Copy link
Contributor Author
tohann commented Mar 10, 2014

Added! Apologies for missing the tests the first time around.

@n1k0
Copy link
Member
n1k0 commented Mar 10, 2014

No worries. The build has failed because of jshint issues:

tests/suites/clientutils.js: line 211, col 14, 'info' is already defined.
tests/suites/clientutils.js: line 215, col 14, 'info' is already defined.
tests/suites/clientutils.js: line 219, col 14, 'info' is already defined.

Could you please take care of fixing these and rebase your work into a single commit? Thanks!

@tohann
Copy link
Contributor Author
tohann commented Mar 10, 2014

I'm having some issues rebasing since I already pushed the prior changes. Would you recommend doing a force push in this instance?

@n1k0
Copy link
Member
n1k0 commented Mar 10, 2014

Sure, that's probably the only case where push -f is safe :)

@tohann
Add style.display check for inline-block when determining element vis…
b754bf8 
…ibility

When checking for visibility, style.display is checked to match
“inline”.  Added a check for “inline-block”.
@tohann
Copy link
Contributor Author
tohann commented Mar 10, 2014

Ok, that's what I figured but wanted to run it by you first. :) Force pushed!

n1k0 added a commit that referenced this pull request Mar 10, 2014
@n1k0
Merge pull request #855 from tohann/master
c87131c 
Add style.display check for inline-block when determining element visibility
@n1k0 n1k0 merged commit c87131c into casperjs:master Mar 10, 2014
@n1k0
Copy link
Member
n1k0 commented Mar 10, 2014

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Qualified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tohann @n1k0
0