8000 update test.success event by r8k · Pull Request #891 · casperjs/casperjs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 19, 2020. It is now read-only.

update test.success event #891

Merged
merged 1 commit into from
Apr 18, 2014
Merged

update test.success event #891

merged 1 commit into from
Apr 18, 2014

Conversation

r8k
Copy link
Contributor
@r8k r8k commented Apr 18, 2014
  • fix casper.test.on.pass to casper.test.on.success
  • fixes #890

@r8k
update test.success event
332e638 
 * fix casper.test.on.pass to casper.test.on.success
 * fixes #890
@r8k
Copy link
Contributor Author
r8k commented Apr 18, 2014

@mickaelandrieu @n1k0 can you please review this, and let me know, if everything is fine.

mickaelandrieu added a commit that referenced this pull request Apr 18, 2014
@mickaelandrieu
Merge pull request #891 from r8k/master
06d6dc2 
update test.success event
@mickaelandrieu mickaelandrieu merged commit 06d6dc2 into casperjs:master Apr 18, 2014
@mickaelandrieu
Copy link
Member

Thanks !

@Fanch-
Copy link
Fanch- commented Apr 23, 2014

Hum... still not updated:
http://docs.casperjs.org/en/1.1-beta3/modules/tester.html#getfailures

See the Note below getFailures() :
"In CasperJS 1.1, you can store test successes by recording them listening to the tester pass event:" -> should be test failures and 'fail' event

And for test.success, below getPasses():
It should be success x2 instead of 'pass'.

@n1k0
Copy link
Member
n1k0 commented Apr 23, 2014

Hmm that's right.

n1k0 added a commit that referenced this pull request Apr 23, 2014
@n1k0
refs #891 - fixed docs for tester events
9802132
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r8k @mickaelandrieu @Fanch- @n1k0
0