Improvements to flat vector search #2512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2512 +/- ##
============================================
+ Coverage 67.07% 67.09% +0.01%
- Complexity 1469 1472 +3
============================================
Files 218 219 +1
Lines 12585 12628 +43
Branches 1523 1526 +3
============================================
+ Hits 8442 8473 +31
- Misses 3618 3628 +10
- Partials 525 527 +2 ☔ View full report in Codecov by Sentry. |
MXueguang
approved these changes
Jun 3, 2024
Panizghi
pushed a commit
to Panizghi/anserini
that referenced
this pull request
Jul 9, 2024
+ Two separate codecs: AnseriniLucene99FlatVectorFormat and AnseriniLucene99ScalarQuantizedVectorsFormat.
+ Hooked everything up to regressions for all BEIR datasets: {cached, ONNX} x {original, int8}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This huge PR is ready for review.
I've hooked everything up to regressions, now we have complete set of regressions for all BEIR datasets: {cached, ONNX} x {original, int8}.
We now have two separate codecs:
AnseriniLucene99FlatVectorFormatandAnseriniLucene99ScalarQuantizedVectorsFormat.Mostly looking for a sanity check. In process of re-running all regressions to make sure everything still works.