Adds fusion feature for Anserini #2590
Conversation
…yserini convention
pom.xml
Outdated
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.junit.jupiter</groupId> |
|
|
||
| // Constructor with reSort parameter | ||
| public TrecRun(Path filepath, Boolean reSort) throws IOException { | ||
| this.resetData(); |
There was a problem hiding this comment.
consistent two space indentation?
| } | ||
|
|
||
| private void resetData() { | ||
| runData = new ArrayList<>(); |
| @@ -0,0 +1,3 @@ | |||
| 1 Q0 pyeb86on 1 24 reciprocal_rank_fusion_k=60 | |||
There was a problem hiding this comment.
put all these files under a fusion/ directory please.
There was a problem hiding this comment.
These test files were actually from Daniel early on; I didn't include my test files on the commit. Of course, I could move these to a fusion/ directory or just delete them.
There was a problem hiding this comment.
If these files are actually used, then please move. If they're not, then remove.
| @@ -0,0 +1,76 @@ | |||
| package io.anserini.trectools; | |||
|
Oh, I see, you're modeling the structure after pyserini... yea, let's do a from-ground-up redesign. |
|
|
||
| @Before | ||
| public void setUp() throws IOException { | ||
| sampleFilePath = Paths.get("runs/testlong/run.neuclir22-zh-en-splade.splade.topics.neuclir22-en.splade.original-desc_title.txt"); |
There was a problem hiding this comment.
Can you check? This file doesn't exist...?
Please verify that the test cases are actually doing something...
There was a problem hiding this comment.
So sorry. The file seemed a bit too big for git. The plan was to bring this up when doing more tests after the code style/structure is accepted.
The design is following :
Did a number of tests on codes but not thorough enough. Will test more if the design is accepted.
Should close #2355 and the results align with pyserini.