Added SPLADE-v3 ONNX regression #2818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @clides can we do DL19 and DL20 in the same PR? |
…ild and change the scores if necessary)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2818 +/- ##
=========================================
Coverage 70.16% 70.16%
Complexity 1308 1308
=========================================
Files 187 187
Lines 11918 11918
Branches 1419 1419
=========================================
Hits 8362 8362
Misses 3030 3030
Partials 526 526 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yep, I added both |
lintool
requested changes
May 31, 2025
README.md
Outdated
| @@ -183,7 +183,7 @@ See individual pages for details. | |||
| | SPLADEv2 | [🫙](docs/regressions/regressions-msmarco-v1-passage.distill-splade-max.cached.md) | | | | |||
| | SPLADE++ CoCondenser-EnsembleDistil | [🫙](docs/regressions/regressions-msmarco-v1-passage.splade-pp-ed.cached.md)[🅾️](docs/regressions/regressions-msmarco-v1-passage.splade-pp-ed.onnx.md) | [🫙](docs/regressions/regressions-dl19-passage.splade-pp-ed.cached.md)[🅾️](docs/regressions/regressions-dl19-passage.splade-pp-ed.onnx.md) | [🫙](docs/regressions/regressions-dl20-passage.splade-pp-ed.cached.md)[🅾️](docs/regressions/regressions-dl20-passage.splade-pp-ed.onnx.md) | | |||
| | SPLADE++ CoCondenser-SelfDistil | [🫙](docs/regressions/regressions-msmarco-v1-passage.splade-pp-sd.cached.md)[🅾️](docs/regressions/regressions-msmarco-v1-passage.splade-pp-sd.onnx.md) | [🫙](docs/regressions/regressions-dl19-passage.splade-pp-sd.cached.md)[🅾️](docs/regressions/regressions-dl19-passage.splade-pp-sd.onnx.md) | [🫙](docs/regressions/regressions-dl20-passage.splade-pp-sd.cached.md)[🅾️](docs/regressions/regressions-dl20-passage.splade-pp-sd.onnx.md) | | |||
| | SPLADEv3 | [🫙](docs/regressions/regressions-msmarco-v1-passage.splade-v3.cached.md) | [🫙](docs/regressions/regressions-dl19-passage.splade-v3.cached.md) | [🫙](docs/regressions/regressions-dl20-passage.splade-v3.cached.md) | | |||
| | SPLADEv3 | [🫙](docs/regressions/regressions-msmarco-v1-passage.splade-v3.cached.md)[🅾️](docs/regressions/regressions-msmarco-v1-passage.splade-v3.onnx.md) | [🫙](docs/regressions/regressions-dl19-passage.splade-v3.cached.md) | [🫙](docs/regressions/regressions-dl20-passage.splade-v3.cached.md) | | |||
There was a problem hiding this comment.
I think you need to add links to ONNX here too?
There was a problem hiding this comment.
Yep, just pushed it, forgot to commit and push the change
lintool
approved these changes
May 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added SPLADE-v3 ONNX regression for this issue: #2815