Add Seyed Erfan Yazdanparast to onboarding reproduction logs #2827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please continue along the onboarding path until you reach the end of the exercises, and then we'll take a look all at once. |
|
Dear Professor Lin,
Thank you for your feedback on my pull request. I apologize for my
misunderstanding regarding the process. I truly appreciate your guidance.
I will do my utmost to complete the entire onboarding path as quickly and
thoroughly as possible.
Best regards,
Seyed Erfan Yazdanparast
…On Sun, Jun 8, 2025 at 4:02 PM Jimmy Lin ***@***.***> wrote:
*lintool* left a comment (castorini/anserini#2827)
<#2827 (comment)>
Please continue along the onboarding path until you reach the end of the
exercises, and then we'll take a look all at once.
—
Reply to this email directly, view it on GitHub
<#2827 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALWWWC2X4KS5IUWY65PTCD33CQUPNAVCNFSM6AAAAAB624S5WOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNJUGAZTGOBYGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Why is the diff so large for some of the files? |
|
The reason the diffs are relatively large is that my fork was based on the
castorini/anserini repository, which already included the following files:
-
docs/start-here.md
-
docs/experiments-msmarco-passage.md
-
docs/experiments-msmarco-passage2.md
However, it did not include the files needed for parts 5, 6, and 7 of the
onboarding path:
-
docs/conceptual-framework.md
-
docs/conceptual-framework2.md
-
docs/experiments-nfcorpus.md
To follow the onboarding steps properly, I added these missing files to my
fork. Since they were not previously present, they appear in the diff as
entirely new additions, which might explain the larger size.
…On Sun, Jun 8, 2025 at 11:22 PM Jimmy Lin ***@***.***> wrote:
*lintool* left a comment (castorini/anserini#2827)
<#2827 (comment)>
Why is the diff so large for some of the files?
—
Reply to this email directly, view it on GitHub
<#2827 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALWWWC7RITCY7PL7GKR74C33CSIBRAVCNFSM6AAAAAB624S5WOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNJUGI2DONJXHE>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
If done correctly, your diff should look something like this: #2825 |
|
I've removed unrelated files. Now only the relevant reproduction logs remain. Thank you for reviewing. |
lintool
requested changes
Jun 8, 2025
docs/experiments-msmarco-passage.md
Outdated
| + Results reproduced by [@kevin-zkc](https://github.com/kevin-zkc) on 2025-06-05 (commit [`173312d`](https://github.com/castorini/anserini/commit/173312d7798c343b3cc1d7a3988b213b044eda82)) | ||
| + Results reproduced by [@erfan-yazdanparast](https://github.com/erfan-yazdanparast) on 2025-06-08 (commit [`eefe303`](https://github.com/erfan-yazdanparast/anserini/commit/eefe30319d6a4a3c96d7e3bfcf833cb8c01b5d71)) |
There was a problem hiding this comment.
This should point to a commit in castorini/anserini
lintool
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System Info:
OS: Windows 10 (64-bit)
Shell: Git Bash (MINGW64)
Python: 3.12
Java: 11
Maven: 3.9.10
Status:
Successfully completed all steps from the MS MARCO onboarding guide
Downloaded and unpacked the MS MARCO passage collection and queries
Note: The original wget command failed on Windows
(wget https://msmarco.z22.web.core.windows.net/msmarcoranking/collectionandqueries.tar.gz -P collections/msmarco-passage)
so I used curl instead:
curl -o collections/msmarco-passage/collectionandqueries.tar.gz https://msmarco.z22.web.core.windows.net/msmarcoranking/collectionandqueries.tar.gz
Notes:
Everything else worked fine. The instructions were clear. I did not encounter other issues.