8000 Add -dryRun and -printCommands to io.anserini.reproduce.RunRepro by lintool · Pull Request #2880 · castorini/anserini · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add -dryRun and -printCommands to io.anserini.reproduce.RunRepro #2880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 5, 2025
Merged

Add -dryRun and -printCommands to io.anserini.reproduce.RunRepro #2880

merged 5 commits into from
Jul 5, 2025

Conversation

lintool
Copy link
Member
@lintool lintool commented Jul 5, 2025

As a result, the fatjar docs don't need to explicitly render commands. So we can do something like:

bin/run.sh io.anserini.reproduce.RunMsMarco -collection msmarco-v2.1-doc -dryRun -printCommands

@codecov Codecov
Copy link
codecov bot commented Jul 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 59.45946% with 30 lines in your changes missing coverage. Please review.

Project coverage is 71.64%. Comparing base (5edd2b2) to head (d8281bf).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/main/java/io/anserini/reproduce/RunRepro.java 53.44% 24 Missing and 3 partials ⚠️
...rc/main/java/io/anserini/reproduce/RunMsMarco.java 62.50% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2880      +/-   ##
============================================
+ Coverage     71.06%   71.64%   +0.57%     
- Complexity     1289     1301      +12     
============================================
  Files           184      184              
  Lines         12012    12039      +27     
  Branches       1402     1408       +6     
============================================
+ Hits           8536     8625      +89     
+ Misses         2957     2889      -68     
- Partials        519      525       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lintool lintool requested a review from wu-ming233 July 5, 2025 15:59
@lintool
Copy link
Member Author
lintool commented Jul 5, 2025

@wu-ming233 I added tests, but it's not practical to cover the non-dry-run branches in order to get test coverage up.

wu-ming233
wu-ming233 approved these changes Jul 5, 2025
View reviewed changes
Copy link
Member
@wu-ming233 wu-ming233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@lintool lintool merged commit 5f662f4 into master Jul 5, 2025
2 of 3 checks passed
@lintool lintool deleted the fatjar-regressions branch July 5, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-ming233 wu-ming233 wu-ming233 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lintool @wu-ming233
0