8000 Fix Helm Implementation generation for empty objects and arrays in Capact CLI by pkosiec · Pull Request #664 · capactio/capact · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Helm Implementation generation for empty objects and arrays in Capact CLI #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2022
Merged

Fix Helm Implementation generation for empty objects and arrays in Capact CLI #664

merged 1 commit into from
Mar 16, 2022

Conversation

pkosiec
Copy link
Member
@pkosiec pkosiec commented Mar 14, 2022 •
edited
Loading

Description

Changes proposed in this pull request:

  • Fix Helm Implementation generation for empty objects and arrays in Capact CLI
  • Allow additional properties for objects generated with

Testing

To test this PR, check out this branch and run:

# with old CLI
capact manifest generate implementation helm cap.implementation.secret-storage-backend.install ./deploy/kubernetes/charts/secret-storage-backend -o /tmp/generated-old

# with new CLI, from this branch
go run ./cmd/cli/main.go manifest generate implementation helm cap.implementation.secret-storage-backend.install ./deploy/kubernetes/charts/secret-storage-backend -o /tmp/generated-new

You can compare the values with real manifests from https://github.com/capactio/hub-manifests/blob/main/manifests/implementation/aws/secrets-manager/storage/install.yaml

For more details, see the Steps to reproduce from #663.

Related issue(s)

Resolves #663

@pkosiec pkosiec added bug Something isn't working area/cli Relates to CLI labels Mar 14, 2022
@pkosiec pkosiec force-pushed the fix-helm-generation branch from ca6b86d to fcd5aa0 Compare March 14, 2022 17:10
mkuziemko
mkuziemko approved these changes Mar 16, 2022
View reviewed changes
Copy link
@mkuziemko mkuziemko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally and looks good 👍

@pkosiec pkosiec merged commit ac082e2 into capactio:main Mar 16, 2022
@pkosiec pkosiec deleted the fix-helm-generation branch March 16, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7D96
Reviewers

@mkuziemko mkuziemko mkuziemko approved these changes

@tmitchell tmitchell Awaiting requested review from tmitchell tmitchell is a code owner

@mszostok mszostok Awaiting requested review from mszostok mszostok is a code owner

Assignees

@mkuziemko mkuziemko

Labels
area/cli Relates to CLI bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm generator generates invalid Helm runner arguments for empty objects and arrays
2 participants
@pkosiec @mkuziemko
0