8000 Set init statement and autoSelectLimit for maxcompute source by shydefoo · Pull Request #645 · caraml-dev/merlin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Set init statement and autoSelectLimit for maxcompute source #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2025
Merged

Set init statement and autoSelectLimit for maxcompute source #645

merged 2 commits into from
May 14, 2025

Conversation

shydefoo
Copy link
Contributor
@shydefoo shydefoo commented May 2, 2025

Description

  • This MR configures the maxcompute source in merlin-batch-predictor to do a full table scan and increases the select limit to 1 billion rows instead of the default 1 million rows

Modifications

Tests

Checklist

  • Added PR label
  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduces API changes

Release Notes

@shydefoo shydefoo requested review from anantadwi13 and bthari May 2, 2025 05:43
bthari
bthari approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor
@bthari bthari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the limit, LGTM! 🚀

@shydefoo shydefoo added bug Something isn't working enhancement New feature or request labels May 14, 2025
@shydefoo shydefoo merged commit 0353ae3 into main May 14, 2025
34 of 35 checks passed
@shydefoo shydefoo deleted the fix-batch-predictor-row-limit-issue branch May 14, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anantadwi13 anantadwi13 anantadwi13 approved these changes

@bthari bthari bthari approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shydefoo @anantadwi13 @bthari
0