Add reflink_block function #85
Conversation
src/lib.rs
Outdated
| /// - The destination region must not extend past the end of file. If the application wishes to | ||
| /// extend the destination with cloned data, it must first call | ||
| /// [`File::set_len`](fn@std::fs::File::set_len). |
There was a problem hiding this comment.
Hmmm...
File::set_len is probably cheap on Linux, but this still makes the API slightly different on different platforms.
There was a problem hiding this comment.
In most cases, it should be possible to preallocate required space for the file on any platform. I would it as a better approach than writing platform specific code. We can add to documentation later
Co-authored-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com> Signed-off-by: Vaiz <4908982+Vaiz@users.noreply.github.com>
|
@NobodyXu , hey, I won't have time to work on this PR in December. There's no rush to get it merged, so we can either leave it as is for now, or I can create a new PR later. If you prefer, feel free to finish it yourself |
|
That's totally fine, it's almost Christmas time and everyone is taking a break to relax themselves. There is no need to rush anything, wish you have a nice Christmas! |
* remove commented code * move mandatory arguments to constructor
Adding block-level reflink capabilities allows for more granular and efficient data management. This can be particularly beneficial for applications that need to clone or deduplicate specific segments of large files.
Details:
--ignoredwith--include-ignoredfor cargo test to enable all testsreflink_block, although it should be possible to add linux support in the future without changing function signaturereflink_blockaccepts immutable reference to target file to allow calling this function on the same fileissue: #80