8000 utils.create_cd: feature_names indices are shifted by one · Issue #2211 · catboost/catboost · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

utils.create_cd: feature_names indices are shifted by one #2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andrey-khropov opened this issue Oct 31, 2022 · 0 comments
Closed

utils.create_cd: feature_names indices are shifted by one #2211

andrey-khropov opened this issue Oct 31, 2022 · 0 comments
Assignees
@andrey-khropov
Labels
bug

Comments

@andrey-khropov
Copy link
Member 
    One more issue: feature_names indices are shifted by one: https://github.com/catboost/catboost/blame/master/catboost/python-package/catboost/utils.py#L100

This is:

  1. Very strange and inconsistent with other arguments of the same function
  2. Not reflected in the documentation. Usage examples seem to assume that feature enumeration is consistent between feature_names and cat_features https://catboost.ai/en/docs/concepts/python-reference_utils_create_cd

Originally posted by @AlexeySalmin in #2193 (comment)
@andrey-khropov andrey-khropov mentioned this issue Oct 31, 2022
Closed
@andrey-khropov andrey-khropov self-assigned this Oct 31, 2022
arcadia-devtools pushed a commit that referenced this issue Nov 20, 2022
@andrey-khropov
create_cd fix: dict keys in feature_names are column indices. Add tes…
e5fa822 
…ts. MLTOOLS-6777. Fixes #2211.

ref:258c059d9a1db9e733200123b17179baa9474189
arcadia-devtools pushed a commit that referenced this issue Nov 26, 2022
@andrey-khropov
create_cd fix: dict keys in feature_names are column indices. Add tes…
723e474 
…ts. MLTOOLS-6777
8000
. Fixes #2211.

ref:4316f7b652ac40ae03a5b09ab0affb0b3211d36a
arcadia-devtools pushed a commit that referenced this issue Dec 1, 2022
@andrey-khropov
create_cd fix: dict keys in feature_names are column indices. Add tes…
65b8987 
…ts. MLTOOLS-6777. Fixes #2211.

ref:91a08ab176f51a8162929bc6d259b70a61b12374
robot-piglet pushed a commit that referenced this issue Dec 24, 2022
@andrey-khropov
create_cd fix: dict keys in feature_names are column indices. Add tes…
efbb5f0 
…ts. MLTOOLS-6777. Fixes #2211.

ref:957749fe7a7fa4ea96137157d2bd7fc4ccc63135
robot-piglet pushed a commit that referenced this issue Jan 17, 2023
@andrey-khropov
create_cd fix: dict keys in feature_names are column indices. Add tes…
97f1a28 
…ts. MLTOOLS-6777. Fixes #2211.

ref:bf6bdd3a5624a4e3d9a6796b95e3855c771917f0
robot-piglet pushed a commit that referenced this issue Jan 17, 2023
@andrey-khropov
create_cd fix: dict keys in feature_names are column indices. Add tes…
c0b0fdb 
…ts. MLTOOLS-6777. Fixes #2211.

ref:258c059d9a1db9e733200123b17179baa9474189
robot-piglet pushed a commit that referenced this issue Jan 17, 2023
@andrey-khropov
create_cd fix: dict keys in feature_names are column indices. Add tes…
362b5e9 
…ts. MLTOOLS-6777. Fixes #2211.

ref:4316f7b652ac40ae03a5b09ab0affb0b3211d36a
robot-piglet pushed a commit that referenced this issue Jan 17, 2023
@andrey-khropov
create_cd fix: dict keys in feature_names are column indices. Add tes…
7ee59bd 
…ts. MLTOOLS-6777. Fixes #2211.

ref:91a08ab176f51a8162929bc6d259b70a61b12374
robot-piglet pushed a commit that referenced this issue Jan 17, 2023
@andrey-khropov
create_cd fix: dict keys in feature_names are column indices. Add tes…
d94e4a2 
…ts. MLTOOLS-6777. Fixes #2211.

ref:957749fe7a7fa4ea96137157d2bd7fc4ccc63135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrey-khropov andrey-khropov

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrey-khropov
0