Fix(lint): Address multiple linting issues across the codebase #990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses a series of linting issues identified by golangci-lint, improving code quality and consistency. Key changes include: - **Error Handling:** - Correctly handle errors returned from functions such as `pprof.StartCPUProfile`, `json.Unmarshal`, `w.Write`, `encoder.Encode`, `decoder.Decode`, `tx.Commit`, and `os.MkdirAll`. - Ignored errors from `tx.Rollback` as the transaction is already in a failed state. - **Deprecated Code:** - Replaced deprecated `io/ioutil` with the `os` package. - Replaced deprecated `quad.Raw` and `quad.MakeRaw` with `quad.IRI` and `quad.MakeIRI` respectively. - **Code Cleanup:** - Removed unused variables and functions to improve code readability. - Eliminated ineffectual assignments. - **Tooling:** - Introduced a `run_linter.sh` script to streamline the linting process.
This commit resolves a batch of 7 linting errors found in the /examples directory to improve code quality and maintainability. Key changes include: - Replaced the deprecated `io/ioutil` package with `os` for temporary directory creation in `hello_bolt/main.go` and `hello_schema/main.go`. - Removed an unused `rdfType` field from the Person struct in `hello_schema/main.go`. - Replaced `nil` context arguments with `context.TODO()` in `hello_schema/main.go` and `hello_world/main.go` to adhere to best practices for context propagation.
dennwc
requested changes
Jun 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses a series of linting issues identified by golangci-lint, improving code quality and consistency.
Key changes include:
Error Handling:
pprof.StartCPUProfile,json.Unmarshal,w.Write,encoder.Encode,decoder.Decode,tx.Commit, andos.MkdirAll.tx.Rollbackas the transaction is already in a failed state.Deprecated Code:
io/ioutilwith theospackage.quad.Rawandquad.MakeRawwithquad.IRIandquad.MakeIRIrespectively.Code Cleanup:
Tooling:
run_linter.shscript to streamline the linting process.This change is