8000 XRB should be rewritten to NANO · Issue #2561 · ccxt/ccxt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

XRB should be rewritten to NANO #2561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gosuto-inzasheru opened this issue Apr 12, 2018 · 5 comments
Closed

XRB should be rewritten to NANO #2561

gosuto-inzasheru opened this issue Apr 12, 2018 · 5 comments
Assignees
@kroitor
Labels
duplicate question

Comments

@gosuto-inzasheru
Copy link

The manual explains that some symbols get rewritten automatically (e.g. XBT, DSH). I think this should be the case for XRB as wel. RaiBlocks went through a rebranding and are now called NANO. Confusingly enough binance.fetchBalance()['info'] returns NANO results whereas binance.fetchBalance()['total'] returns XRB.

Digging through the code I think this pair is actually just defined the wrong way around:

ccxt/python/ccxt/binance.py

Line 264 in 4c5df8e

'NANO': 'XRB',

  • OS: macOS
  • Programming Language version: Python
  • CCXT version: 1.12.156
  • Exchange: binance
  • Method: fetchBalance()
@kroitor kroitor self-assigned this Apr 12, 2018
@kroitor
Copy link
Member
kroitor commented Apr 12, 2018 •
edited
Loading

Wherever the info is returned inside a response from a CCXT unified method – that is the raw unparsed exchange response, as is. Therefore it contains ids. And the rest of the fetchBalance response around info is the unified and parsed balance info, according to the Manual: https://github.com/ccxt/ccxt/wiki/Manual#querying-account-balance

Hope this answers your post )

@kroitor kroitor closed this as completed Apr 12, 2018
@kroitor
Copy link
Member
kroitor commented Apr 12, 2018

UPD. Added a few more clarifications to this.

kroitor added a commit that referenced this issue Apr 12, 2018
@kroitor
added clarifications on XRB vs NANO to the Manual #2561
51a4145
@kroitor
Copy link
Member
kroitor commented Apr 12, 2018

One of the reasons for not using the NANO code is that CoinMarketCap uses XRB, and NANO designates a different token there.

@arielorvits
Copy link
Contributor

@kroitor
not sure u're right regarding CMC
https://coinmarketcap.com/currencies/nano/
https://coinmarketcap.com/search/?q=xrb

@kroitor
Copy link
Member
kroitor commented Apr 13, 2018

screen shot 2018-04-13 at 06 02 09

@arielorvits yep, thank you! Looks like CMC actually uses NANO now, and we will probably use NANO as well starting from 1.13. Will fix it soon and will let you know.

@kroitor kroitor mentioned this issue Apr 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kroitor kroitor

Labels
duplicate question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kroitor @gosuto-inzasheru @arielorvits
0