fix(bybit): unWatch orders/mytrades #26326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcriadoperez
reviewed
Jul 2, 2025
| @@ -7818,16 +7818,34 @@ export default class Exchange { | |||
| throw new NotSupported (this.id + ' fetchTransfers () is not supported yet'); | |||
| } | |||
|
|
|||
| cleanUnsubscription (client, subHash: string, unsubHash: string) { | |||
| cleanUnsubscription (client, subHash: string, unsubHash: string, subHashIsPrefix = false) { | |||
There was a problem hiding this comment.
In which cases subHashIsPrefix = true?
can we always delete the futures and subscriptions where sub.startsWith (subHash) ?
There was a problem hiding this comment.
@pcriadoperez When for instance the subHash is orders but the subscriptions are orders:LTC/USDT, orders:BTC/USDT, etc
can we always delete the futures and subscriptions where sub.startsWith (subHash) ?
@pcriadoperez I don't think so, what if the subHash orders:LTC/USDT but in subscriptions you have orders:LTC/USDT:USDT ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.